Skip to content

Comments

Added metallicity dependence to martinez26 and added martinez26_ecsn#760

Open
MarkGM02 wants to merge 4 commits intoCOSMIC-PopSynth:developfrom
MarkGM02:develop
Open

Added metallicity dependence to martinez26 and added martinez26_ecsn#760
MarkGM02 wants to merge 4 commits intoCOSMIC-PopSynth:developfrom
MarkGM02:develop

Conversation

@MarkGM02
Copy link
Contributor

Changed the primary mass from 8M⊙ to 6.8M⊙ which divides high and low mass stars for the martinez26 orbital period option. This cutoff mass was chosen since it is the minimum mass for an FeCCSN at COSMIC's lowest metallicity, when default winds are used.

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 40.42553% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.78%. Comparing base (8772c07) to head (bec121f).
⚠️ Report is 137 commits behind head on develop.

Files with missing lines Patch % Lines
src/cosmic/sample/sampler/independent.py 0.00% 28 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #760      +/-   ##
===========================================
- Coverage    86.91%   77.78%   -9.13%     
===========================================
  Files           40       50      +10     
  Lines        25542    27555    +2013     
  Branches         0      921     +921     
===========================================
- Hits         22198    21431     -767     
- Misses        3344     5837    +2493     
- Partials         0      287     +287     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@katiebreivik
Copy link
Collaborator

@TomWagg mentioned that we might consider making this a metallicity-specific limit but I’m happy to merge with the inclusive 6.8 Msun limit for now once that one comment is addressed above.

@TomWagg
Copy link
Collaborator

TomWagg commented Feb 18, 2026

Yeah I think you could make a pretty simple prescription that accounts for the metallicity dependence. Here's a grid of single stars from COSMIC and a (very crude) (but not bad!) fit :)

image

@TomWagg
Copy link
Collaborator

TomWagg commented Feb 18, 2026

Or you could try fitting any SN maybe?

Here the expressions are as follows:

For CCSN:
$M = 1.1 \log_{10}(Z) + 10.1$, but $M = 6.825$ for $Z < 10^{3}$

For any SN:
$M = 1.1 \log_{10}(Z) + 10.1$ at $Z > 10^3$, $M = 6.38$ for $Z < 3\times10^{4}$, and $M = 0.8 \log_{10}(Z) + 9.2$ in between.

image

@MarkGM02
Copy link
Contributor Author

image

Implemented this using linear interpolation in log-metallicity between nearest grid points from my single star grids!

@MarkGM02
Copy link
Contributor Author

The mass cutoff is the FeCCSN minimum mass for martinez26 and the ECSN mass for martinez26_ecsn.

@MarkGM02 MarkGM02 changed the title Changed martinez26 orbital period cutoff mass Added metallicity dependence to martinez26 orbital period and added martinez26_ecsn Feb 19, 2026
@MarkGM02 MarkGM02 changed the title Added metallicity dependence to martinez26 orbital period and added martinez26_ecsn Added metallicity dependence to martinez26 and added martinez26_ecsn Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants